fix!: exclude clutter from the component API #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
React devs are used to using the aria-label from React.HTMLAttributes anyway
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #167 +/- ##
=======================================
Coverage 98.21% 98.21%
=======================================
Files 25 25
Lines 168 168
Branches 16 16
=======================================
Hits 165 165
Misses 1 1
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
web-padawan
previously approved these changes
Dec 11, 2023
|
Confirmed that this PR also fixes #150
|
web-padawan
approved these changes
Dec 11, 2023
tomivirkki
changed the title
This was referenced Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Omit unnecessary parts of
HTMLElementinterface from all Vaadin React components. This will eliminate clutter from the component public API including properties such asparentElement,offsetHeight, andappendChild.Before:
After:
Also,
ControllerMixinClassproperties (addControllerandremoveController) are manually excluded.Part of #161
Fixes #137
Fixes #150
Fixes #165
Type of change
Refactor